pass tolerance value when calling sub-routines#99
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 24 24
Lines 5132 5132
=======================================
Hits 3881 3881
Misses 1251 1251 ☔ View full report in Codecov by Sentry. |
jcao-bdai
requested review from
jhavl,
myeatman-bdai and
petercorke
as code owners
Collaborator
|
Looks good to me. |
myeatman-bdai
approved these changes
Nov 27, 2023
jcao-bdai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to improve consistency of tolerance usages in various checks (e.g.
ishom,isR, etc.), it fixes a couple of simple issues where thetol(erance)is set but not passed to sub-routines.